fix: error suppressing tests on packages#4996
Merged
auto-submit[bot] merged 5 commits intomainfrom Mar 24, 2026
Merged
Conversation
various problems: - dialog widgets aren't mounted and getting dismissed - githubService.getIssue() is odd (Future<Issue>?) - Add fake auth to dashboard for non-prod - Add fake issue response for testing - see flutter/packages
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This PR addresses multiple issues across the project, including handling missing dialog widget mounting, enhancing the fake auth integration in the dashboard, and extending test data seeding logic. Overall, the implementation correctly resolves the issues and adds appropriate error handling and test coverage.
🔍 General Feedback
- Good additions of mock behavior (
fakeGetIssue) and tests to ensure the changes are adequately covered. - The use of the
try...catchblock inUpdateSuppressedTestis a good addition for robustness but should avoid catching and masking expected exceptions. - Be careful with Dart map syntax for conditionally including elements, especially when migrating to newer patterns.
- Excellent job on providing fake implementations (
FakeFirebaseAuthService) for non-production environments to streamline development and testing.
ievdokdm
requested changes
Mar 24, 2026
jtmcdole
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
various problems: